Skip to content

Update TypeSpec for 2025-06-01#39481

Merged
wiboris merged 21 commits intomainfrom
Batch-MagementPlane-TypeSpec-Update
Feb 10, 2026
Merged

Update TypeSpec for 2025-06-01#39481
wiboris merged 21 commits intomainfrom
Batch-MagementPlane-TypeSpec-Update

Conversation

@wiboris
Copy link
Member

@wiboris wiboris commented Jan 6, 2026 •
edited
Loading

Previously we shipped a updated typespec for 2025-06-01 #35105 which had all the breaking changes approved. That PR had to be reverted because it wasn't created with typespec. This PR has the same updates and breaking changes as the previous PR but this time its TypeSpec based.

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

Previously we shipped a updated typespec for 2025-06-01 #35105 which had all the breaking changes approved. That PR had to be reverted because it wasn't created with typespec. This PR has the same updates and breaking changes as the previous PR but this time its TypeSpec based.

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

@github-actions
Copy link

github-actions bot commented Jan 6, 2026 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added ARMReview resource-manager TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 6, 2026
@github-actions
Copy link

github-actions bot commented Jan 6, 2026 •
edited
Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Microsoft.Batch
Go sdk/resourcemanager/batch/armbatch
JavaScript @azure/arm-batch
Java com.azure.resourcemanager:azure-resourcemanager-batch
Python azure-mgmt-batch
Swagger Microsoft.Batch-Batch

@wiboris wiboris force-pushed the Batch-MagementPlane-TypeSpec-Update branch from 2ffadb7 to f87e248 Compare January 7, 2026 00:49
@wiboris wiboris changed the title Update TypeSpec for 2025-067-01 Update TypeSpec for 2025-06-01 Jan 7, 2026
@wiboris wiboris force-pushed the Batch-MagementPlane-TypeSpec-Update branch from a7b29e8 to 54bd27b Compare January 7, 2026 18:47
@mikekistler mikekistler added the BreakingChange-Approved-BranchPolicyException Changes violate the branch policy but exception has been granted. aka.ms/azsdk/pr-brch-deep label Jan 8, 2026
@github-actions github-actions bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Jan 8, 2026
mikeharder
mikeharder previously requested changes Jan 8, 2026
View reviewed changes
Copy link
Member

@mikeharder mikeharder left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this PR is actually doing two things:

  1. Reverting #35105, which was merged un-intentionally
  2. Adding typespec-generated swagger for 2025-06-01

Instead of combining these in a single PR, I think the cleanest path forward would be:

  • Run git revert 35105, to directly undo the mistake. This revert PR may have breaking changes, but we are just reverting your spec to the last known good status, so it should be safer to bypass failing checks.
  • Create a new PR, from your last-known-good state, to your new desired state. This should give valid results for breaking changes.

@qiaozha
Copy link
Member

qiaozha commented Jan 8, 2026

@mikeharder I am more curious why PR #35105 can be merged, should tsv fail when service team adding new manual authored swaggers after it converted to TypeSpec?

@mikeharder
Copy link
Member

mikeharder commented Jan 8, 2026 •
edited
Loading

@mikeharder I am more curious why PR #35105 can be merged, should tsv fail when service team adding new manual authored swaggers after it converted to TypeSpec?

There is a feature request for this, but not yet implemented:

I will add you to the mail thread with more context.

@gary-x-li
Copy link
Contributor

gary-x-li commented Jan 9, 2026 •
edited
Loading

I believe this PR is actually doing two things:

  1. Reverting Batch Management Plane 2025-06-01 #35105, which was merged un-intentionally
  2. Adding typespec-generated swagger for 2025-06-01

Instead of combining these in a single PR, I think the cleanest path forward would be:

  • Run git revert 35105, to directly undo the mistake. This revert PR may have breaking changes, but we are just reverting your spec to the last known good status, so it should be safer to bypass failing checks.
  • Create a new PR, from your last-known-good state, to your new desired state. This should give valid results for breaking changes.

@wiboris Seems you've done 1, which I've approved. Please create a new PR for 2.

@gary-x-li gary-x-li added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 9, 2026
@sandipsh
Copy link
Contributor

sandipsh commented Feb 4, 2026

please address this comment and once cofirmed as addressed, please request arm review again.

In reply to: 3637429976

@sandipsh
Copy link
Contributor

sandipsh commented Feb 4, 2026

as per Gary's comment, i think 1st one is addressed.

In reply to: 3844487946

@azure-sdk azure-sdk mentioned this pull request Feb 10, 2026
Open
Copilot AI mentioned this pull request Feb 10, 2026
Draft
9 tasks
This was referenced Feb 11, 2026
Draft
Open
Copilot AI mentioned this pull request Feb 11, 2026
Draft
This was referenced Feb 11, 2026
Merged
Merged
Draft
This was referenced Mar 7, 2026
Closed
Draft
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpwatrous dpwatrous dpwatrous approved these changes

@mikeharder mikeharder mikeharder left review comments

@skapur12 skapur12 Awaiting requested review from skapur12 skapur12 is a code owner

@cRui861 cRui861 Awaiting requested review from cRui861 cRui861 is a code owner

@wanghoppe wanghoppe Awaiting requested review from wanghoppe wanghoppe is a code owner

@ReneOv-MSFT ReneOv-MSFT Awaiting requested review from ReneOv-MSFT ReneOv-MSFT is a code owner

@razvanbadea-msft razvanbadea-msft Awaiting requested review from razvanbadea-msft

Assignees

No one assigned

Labels

Approved-Avocado ARMAutoSignedOff-IncrementalTSP ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review Batch BreakingChange-Approved-BranchPolicyException Changes violate the branch policy but exception has been granted. aka.ms/azsdk/pr-brch-deep BreakingChange-Go-Sdk BreakingChange-Go-Sdk-Approved BreakingChange-JavaScript-Sdk BreakingChange-JavaScript-Sdk-Approved BreakingChange-Python-Sdk BreakingChange-Python-Sdk-Approved BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager TypeSpec Authored with TypeSpec

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.